muse2/graph/

validate.rs

//! Module for validating commodity graphs
use super::{CommoditiesGraph, GraphEdge, GraphNode};
use crate::commodity::{CommodityMap, CommodityType};
use crate::process::{Process, ProcessMap};
use crate::region::RegionID;
use crate::time_slice::{TimeSliceInfo, TimeSliceLevel, TimeSliceSelection};
use crate::units::{Dimensionless, Flow};
use anyhow::{Context, Result, ensure};
use indexmap::IndexMap;
use strum::IntoEnumIterator;

/// Prepares a graph for validation with [`validate_commodities_graph`].
///
/// It takes a base graph produced by `create_commodities_graph_for_year`, and modifies it to
/// account for process availabilities and commodity demands within the given time slice selection,
/// returning a new graph.
///
/// Commodity demands are represented by the `Demand` node. We only add edges to the `Demand` node
/// for commodities with the same `time_slice_level` as the selection. Other demands can be ignored
/// since this graph will only be validated for commodities with the same `time_slice_level` as the
/// selection.
fn prepare_commodities_graph_for_validation(
    base_graph: &CommoditiesGraph,
    processes: &ProcessMap,
    commodities: &CommodityMap,
    year: u32,
    time_slice_selection: &TimeSliceSelection,
) -> CommoditiesGraph {
    let mut filtered_graph = base_graph.clone();

    // Filter by process availability
    // We keep edges if the process has availability > 0 in any time slice in the selection
    // Each edge carries the asset's installing region, so we can look up the correct
    // ActivityLimits for that (process, region, year) combination.
    filtered_graph.retain_edges(|graph, edge_idx| {
        // Get the process/region for the edge
        let (process_id, region_id) = match graph.edge_weight(edge_idx).unwrap() {
            GraphEdge::Primary(process_id, region_id)
            | GraphEdge::Secondary(process_id, region_id) => (process_id, region_id),
            GraphEdge::Demand => panic!("Demand edges should not be present in the base graph"),
        };
        let process = &processes[process_id];

        // Check if the process in this region has availability > 0 in any time slice in the
        // selection
        can_be_active(process, &(region_id.clone(), year), time_slice_selection)
    });

    // Add demand edges
    // We add an edge to the `Demand` node for each (commodity, region) pair that has positive
    // demand for this year and time slice selection
    // NOTE: we only do this for commodities with the same time_slice_level as the selection
    let demand_node_index = filtered_graph.add_node(GraphNode::Demand);
    for (commodity_id, commodity) in commodities {
        for ((region_id, dem_year, dem_ts_sel), &flow) in &commodity.demand {
            if *dem_year != year || dem_ts_sel != time_slice_selection || flow <= Flow(0.0) {
                continue;
            }
            let commodity_node = GraphNode::Commodity(commodity_id.clone(), region_id.clone());
            let commodity_node_index = filtered_graph
                .node_indices()
                .find(|&idx| filtered_graph.node_weight(idx) == Some(&commodity_node))
                .unwrap_or_else(|| filtered_graph.add_node(commodity_node));
            filtered_graph.add_edge(commodity_node_index, demand_node_index, GraphEdge::Demand);
        }
    }

    filtered_graph
}

/// Checks if a process can be active for a particular time slice in a given year and region
///
/// It considers all commission years that can lead to a running process in the target region and
/// year, accounting for the process lifetime, and then checks if, for any of those, the process
/// is active in the required time slice. In other words, this checks if there is the _possibility_
/// of having an active process, although there is no guarantee of that happening since it depends
/// on the investment.
fn can_be_active(
    process: &Process,
    target: &(RegionID, u32),
    time_slice_selection: &TimeSliceSelection,
) -> bool {
    let (target_region, target_year) = target;

    for ((region, year), value) in &process.parameters {
        if region != target_region {
            continue;
        }
        if year + value.lifetime >= *target_year {
            let Some(limits_map) = process.activity_limits.get(target) else {
                continue;
            };
            if limits_map.get_limit(time_slice_selection).end() > &Dimensionless(0.0) {
                return true;
            }
        }
    }
    false
}

/// Validates that the commodity graph follows the rules for different commodity types.
///
/// It takes as input a graph prepared by `prepare_commodities_graph_for_validation`, which is built
/// for a specific time slice selection (must match the `time_slice_level` passed to this function).
///
/// The validation is only performed for commodities with the specified time slice level. For full
/// validation of all commodities in the model, we therefore need to run this function for all time
/// slice selections at all time slice levels. This is handled by
/// [`validate_commodity_graphs_for_model`].
fn validate_commodities_graph(
    graph: &CommoditiesGraph,
    commodities: &CommodityMap,
    time_slice_level: TimeSliceLevel,
) -> Result<()> {
    for node_idx in graph.node_indices() {
        // Get the commodity ID and region for the node
        let graph_node = graph.node_weight(node_idx).unwrap();
        let GraphNode::Commodity(commodity_id, region_id) = graph_node else {
            // Skip special nodes
            continue;
        };

        // Only validate commodities with the specified time slice level
        let commodity = &commodities[commodity_id];
        if commodity.time_slice_level != time_slice_level {
            continue;
        }

        // Count the incoming and outgoing edges for the commodity
        let has_incoming = graph
            .edges_directed(node_idx, petgraph::Direction::Incoming)
            .next()
            .is_some();
        let has_outgoing = graph
            .edges_directed(node_idx, petgraph::Direction::Outgoing)
            .next()
            .is_some();

        // Match validation rules to commodity type
        match commodity.kind {
            CommodityType::ServiceDemand => {
                // Cannot have outgoing `Primary`/`Secondary` (non-`Demand`) edges
                let has_non_demand_outgoing = graph
                    .edges_directed(node_idx, petgraph::Direction::Outgoing)
                    .any(|edge| edge.weight() != &GraphEdge::Demand);
                ensure!(
                    !has_non_demand_outgoing,
                    "SVD commodity {commodity_id} in region {region_id} cannot be an input to a process"
                );

                // If it has `Demand` edges, it must have at least one producer
                let has_demand_edges = graph
                    .edges_directed(node_idx, petgraph::Direction::Outgoing)
                    .any(|edge| edge.weight() == &GraphEdge::Demand);
                if has_demand_edges {
                    ensure!(
                        has_incoming,
                        "SVD commodity {commodity_id} in region {region_id} is demanded but has no producers"
                    );
                }
            }
            CommodityType::SupplyEqualsDemand => {
                // SED: if consumed (outgoing edges), must also be produced (incoming edges)
                ensure!(
                    !has_outgoing || has_incoming,
                    "SED commodity {commodity_id} in region {region_id} may be consumed but has no producers"
                );
            }
            CommodityType::Other => {
                // OTH: cannot have both incoming and outgoing edges
                ensure!(
                    !(has_incoming && has_outgoing),
                    "OTH commodity {commodity_id} in region {region_id} cannot have both producers and consumers"
                );
            }
        }
    }

    Ok(())
}

/// Validates commodity graphs for the entire model.
///
/// The validation process checks three time slice levels:
/// - **Annual**: Validates annual-level commodities and processes
/// - **Seasonal**: Validates seasonal-level commodities and processes for each season
/// - **Day/Night**: Validates day/night-level commodities and processes for each time slice
///
/// # Arguments
///
/// * `commodity_graphs` - Commodity graphs for each year, outputted from `build_commodity_graphs_for_model`
/// * `processes` - All processes in the model with their flows and activity limits
/// * `commodities` - All commodities with their types and demand specifications
/// * `time_slice_info` - Time slice configuration (seasons, day/night periods)
///
/// # Errors
///
/// Returns an error if:
/// - Commodity type rules are violated (e.g., SVD commodities being consumed)
/// - Demand cannot be satisfied
pub fn validate_commodity_graphs_for_model(
    commodity_graphs: &IndexMap<u32, CommoditiesGraph>,
    processes: &ProcessMap,
    commodities: &CommodityMap,
    time_slice_info: &TimeSliceInfo,
) -> Result<()> {
    // Validate graphs at all time slice levels (taking into account process availability and demand)
    for (&year, base_graph) in commodity_graphs {
        for ts_level in TimeSliceLevel::iter() {
            for ts_selection in time_slice_info.iter_selections_at_level(ts_level) {
                let graph = prepare_commodities_graph_for_validation(
                    base_graph,
                    processes,
                    commodities,
                    year,
                    &ts_selection,
                );
                validate_commodities_graph(&graph, commodities, ts_level).with_context(|| {
                    format!("Error validating commodity graph for {year} in {ts_selection}")
                })?;
            }
        }
    }
    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::commodity::Commodity;
    use crate::fixture::{assert_error, other_commodity, sed_commodity, svd_commodity};
    use petgraph::graph::Graph;
    use rstest::rstest;
    use std::sync::Arc;

    #[rstest]
    fn validate_commodities_graph_works(
        other_commodity: Commodity,
        sed_commodity: Commodity,
        svd_commodity: Commodity,
    ) {
        let mut graph = Graph::new();
        let mut commodities = CommodityMap::new();

        // Add test commodities (all have DayNight time slice level)
        commodities.insert("A".into(), Arc::new(other_commodity));
        commodities.insert("B".into(), Arc::new(sed_commodity));
        commodities.insert("C".into(), Arc::new(svd_commodity));

        // Build valid graph: A(OTH) -> B(SED) -> C(SVD) ->D(DEMAND)
        let node_a = graph.add_node(GraphNode::Commodity("A".into(), "GBR".into()));
        let node_b = graph.add_node(GraphNode::Commodity("B".into(), "GBR".into()));
        let node_c = graph.add_node(GraphNode::Commodity("C".into(), "GBR".into()));
        let node_d = graph.add_node(GraphNode::Demand);
        graph.add_edge(
            node_a,
            node_b,
            GraphEdge::Primary("process1".into(), "GBR".into()),
        );
        graph.add_edge(
            node_b,
            node_c,
            GraphEdge::Primary("process2".into(), "GBR".into()),
        );
        graph.add_edge(node_c, node_d, GraphEdge::Demand);

        // Validate the graph at DayNight level
        validate_commodities_graph(&graph, &commodities, TimeSliceLevel::Annual).unwrap();
    }

    #[rstest]
    fn validate_commodities_graph_invalid_svd_consumed(
        svd_commodity: Commodity,
        sed_commodity: Commodity,
        other_commodity: Commodity,
    ) {
        let mut graph = Graph::new();
        let mut commodities = CommodityMap::new();

        // Add test commodities (all have DayNight time slice level)
        commodities.insert("A".into(), Arc::new(svd_commodity));
        commodities.insert("B".into(), Arc::new(sed_commodity));
        commodities.insert("C".into(), Arc::new(other_commodity));

        // Build invalid graph: C(OTH) -> A(SVD) -> B(SED) - SVD cannot be consumed
        let node_c = graph.add_node(GraphNode::Commodity("C".into(), "GBR".into()));
        let node_a = graph.add_node(GraphNode::Commodity("A".into(), "GBR".into()));
        let node_b = graph.add_node(GraphNode::Commodity("B".into(), "GBR".into()));
        graph.add_edge(
            node_c,
            node_a,
            GraphEdge::Primary("process1".into(), "GBR".into()),
        );
        graph.add_edge(
            node_a,
            node_b,
            GraphEdge::Primary("process2".into(), "GBR".into()),
        );

        // Validate the graph at DayNight level
        assert_error!(
            validate_commodities_graph(&graph, &commodities, TimeSliceLevel::DayNight),
            "SVD commodity A in region GBR cannot be an input to a process"
        );
    }

    #[rstest]
    fn validate_commodities_graph_invalid_svd_not_produced(svd_commodity: Commodity) {
        let mut graph = Graph::new();
        let mut commodities = CommodityMap::new();

        // Add test commodities (all have DayNight time slice level)
        commodities.insert("A".into(), Arc::new(svd_commodity));

        // Build invalid graph: A(SVD) -> B(DEMAND) - SVD must be produced
        let node_a = graph.add_node(GraphNode::Commodity("A".into(), "GBR".into()));
        let node_b = graph.add_node(GraphNode::Demand);
        graph.add_edge(node_a, node_b, GraphEdge::Demand);

        // Validate the graph at DayNight level
        assert_error!(
            validate_commodities_graph(&graph, &commodities, TimeSliceLevel::DayNight),
            "SVD commodity A in region GBR is demanded but has no producers"
        );
    }

    #[rstest]
    fn validate_commodities_graph_invalid_sed(sed_commodity: Commodity) {
        let mut graph = Graph::new();
        let mut commodities = CommodityMap::new();

        // Add test commodities (all have DayNight time slice level)
        commodities.insert("A".into(), Arc::new(sed_commodity.clone()));
        commodities.insert("B".into(), Arc::new(sed_commodity));

        // Build invalid graph: B(SED) -> A(SED)
        let node_a = graph.add_node(GraphNode::Commodity("A".into(), "GBR".into()));
        let node_b = graph.add_node(GraphNode::Commodity("B".into(), "GBR".into()));
        graph.add_edge(
            node_b,
            node_a,
            GraphEdge::Primary("process1".into(), "GBR".into()),
        );

        // Validate the graph at DayNight level
        assert_error!(
            validate_commodities_graph(&graph, &commodities, TimeSliceLevel::DayNight),
            "SED commodity B in region GBR may be consumed but has no producers"
        );
    }

    #[rstest]
    fn validate_commodities_graph_invalid_oth(
        other_commodity: Commodity,
        sed_commodity: Commodity,
    ) {
        let mut graph = Graph::new();
        let mut commodities = CommodityMap::new();

        // Add test commodities (all have DayNight time slice level)
        commodities.insert("A".into(), Arc::new(other_commodity));
        commodities.insert("B".into(), Arc::new(sed_commodity.clone()));
        commodities.insert("C".into(), Arc::new(sed_commodity));

        // Build invalid graph: B(SED) -> A(OTH) -> C(SED)
        let node_a = graph.add_node(GraphNode::Commodity("A".into(), "GBR".into()));
        let node_b = graph.add_node(GraphNode::Commodity("B".into(), "GBR".into()));
        let node_c = graph.add_node(GraphNode::Commodity("C".into(), "GBR".into()));
        graph.add_edge(
            node_b,
            node_a,
            GraphEdge::Primary("process1".into(), "GBR".into()),
        );
        graph.add_edge(
            node_a,
            node_c,
            GraphEdge::Primary("process2".into(), "GBR".into()),
        );

        // Validate the graph at DayNight level
        assert_error!(
            validate_commodities_graph(&graph, &commodities, TimeSliceLevel::DayNight),
            "OTH commodity A in region GBR cannot have both producers and consumers"
        );
    }
}